Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA dependency issues from PR #148. #150

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 3, 2024

Following up on an issue with dependencies.yaml from #148. See https://github.com/rapidsai/ucxx/pull/148/files#r1440832477.

cc: @ajschmidt8 @pentschev

@bdice bdice requested a review from a team as a code owner January 3, 2024 19:15
@bdice bdice self-assigned this Jan 3, 2024
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdice .

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bradley! 🙏

Had some questions below

@pentschev
Copy link
Member

/merge

@jakirkham
Copy link
Member

Looks like there was a test failure on CI:

FAILED python/ucxx/_lib/tests/test_server_client.py::test_server_client[thread-0-stream] - RuntimeError: Process did not exit cleanly (exit code: 1)

@rapids-bot rapids-bot bot merged commit 5f05790 into rapidsai:branch-0.36 Jan 4, 2024
@pentschev
Copy link
Member

Had to rerun to get it through, I'm still ironing out some of those tests that occasionally fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants